persistent forms now only leaks ther required event handler and not the functions it uses internally.

static/js/persistentforms.js

@@ -1,4 +1,7 @@
-function setCookie(name, value, days) {
+
+saveFormToCookieEvent = (() => {
+
+    function setCookie(name, value, days) {
         let expires = "";
         if (days) {
             const date = new Date();
@@ -6,20 +9,20 @@ function setCookie(name, value, days) {
             expires = "; expires=" + date.toUTCString();
         }
         document.cookie = name + "=" + encodeURIComponent(value) + expires + "; path=/";
-}
+    }
 
-function getCookie(name) {
+    function getCookie(name) {
         const nameEQ = name + "=";
         const ca = document.cookie.split(';');
-    for(let i=0; i < ca.length; i++) {
+        for (let i = 0; i < ca.length; i++) {
             let c = ca[i];
-        while (c.charAt(0)==' ') c = c.substring(1,c.length);
+            while (c.charAt(0) == ' ') c = c.substring(1, c.length);
-        if (c.indexOf(nameEQ) == 0) return decodeURIComponent(c.substring(nameEQ.length,c.length));
+            if (c.indexOf(nameEQ) == 0) return decodeURIComponent(c.substring(nameEQ.length, c.length));
         }
         return null;
-}
+    }
 
-function saveFormToCookie(form) {
+    function saveFormToCookie(form) {
         const formData = new FormData(form);
         for (let element of form.elements) {
             if (element.id) {
@@ -40,15 +43,15 @@ function saveFormToCookie(form) {
                 }
             }
         }
-}
+    }
 
-function saveFormToCookieEvent(evt) {
+    let saveFormToCookieEvent = function(evt) {
         //console.log("save form to cookie: " + evt.target)
         form = evt.target
         saveFormToCookie(form)
-}
+    }
 
-function loadFormFromCookie(form) {
+    function loadFormFromCookie(form) {
         //console.log("Load form from cookie")
         if (!form) {
             return
@@ -83,41 +86,28 @@ function loadFormFromCookie(form) {
         if (updated) {
             htmx.trigger(form, 'formdataloaded')
         }
-}
+    }
 
-function getPersistentForms() {
+    function getPersistentForms() {
         return document.getElementsByClassName("persistent-form");
-}
+    }
 
-function loadFormsFromCookie() {
+    function loadFormsFromCookie() {
         let forms = getPersistentForms();
         for (let i = 0; i < forms.length; i++) {
             loadFormFromCookie(forms[i])
         }
-}
-
-// Most likely not needed.
-/*
-( () => {
-      let forms = getPersistentForms()
-      for (let i = 0; i < forms.length; i++) {
-          forms[i].addEventListener('change', function() {
-              saveFormToCookie(form)
-          })
     }
-  })()
-*/
 
-htmx.on('htmx:load', function(event) {
+    htmx.on('htmx:load', function (event) {
         //console.log("htmx:load")
         loadFormsFromCookie();
-});
+    });
 
-htmx.on('htmx:afterSettle', function(event) {
+    htmx.on('htmx:afterSettle', function (event) {
         //console.log("htmx:afterSettle")
         loadFormsFromCookie();
-});
+    });
 
-// when hx-boost=false
+    return saveFormToCookieEvent
-// Load form data from cookie on page load
+})()
-//document.addEventListener('DOMContentLoaded', loadFormFromCookie);