From 974b4b9ad0e2edbc25c36aea9f0fbf02485ddda9 Mon Sep 17 00:00:00 2001
From: Erik Brakkee <erik@brakkee.org>
Date: Mon, 19 Aug 2024 19:46:39 +0200
Subject: [PATCH] more symmetry. SetupHeartBeat froma agent to server now done
 in separate call.

---
 cmd/agent/agent.go       |  1 +
 pkg/comms/agentserver.go | 33 ++++++++++++++++-----------------
 2 files changed, 17 insertions(+), 17 deletions(-)

diff --git a/cmd/agent/agent.go b/cmd/agent/agent.go
index 22d773b..f10666b 100755
--- a/cmd/agent/agent.go
+++ b/cmd/agent/agent.go
@@ -322,6 +322,7 @@ func main() {
 	if err != nil {
 		panic(err)
 	}
+	comms.SetupHeartBeat(commChannel)
 
 	// initial check
 
diff --git a/pkg/comms/agentserver.go b/pkg/comms/agentserver.go
index 5c61296..924d093 100644
--- a/pkg/comms/agentserver.go
+++ b/pkg/comms/agentserver.go
@@ -68,26 +68,25 @@ func NewCommChannel(role Role, wsConn io.ReadWriteCloser) (CommChannel, error) {
 	}
 	log.Println("Communication channel between agent and converge server established")
 
-	// heartbeat
-	if role == Agent {
-		go func() {
-			for {
-				time.Sleep(10 * time.Second)
-				err := Send(commChannel.SideChannel,
-					ConvergeMessage{
-						Value: HeartBeat{},
-					})
-				if err != nil {
-					log.Println("Sending heartbeat to server failed")
-				}
-			}
-		}()
-	}
-
 	return commChannel, nil
 }
 
-// Sending an event to the other side
+// Communication from agent to server during the session.
+
+func SetupHeartBeat(commChannel CommChannel) {
+	go func() {
+		for {
+			time.Sleep(10 * time.Second)
+			err := Send(commChannel.SideChannel,
+				ConvergeMessage{
+					Value: HeartBeat{},
+				})
+			if err != nil {
+				log.Println("Sending heartbeat to server failed")
+			}
+		}
+	}()
+}
 
 func ListenForAgentEvents(channel GOBChannel,
 	agentInfo func(agent EnvironmentInfo),