eliminating duplicate communications. this caused problems with linkerd

and helm

cmd/policygen/templates/linkerd/application/authorizationpolicy-app.yaml

@@ -0,0 +1,16 @@
+---
+apiVersion: policy.linkerd.io/v1alpha1
+kind: AuthorizationPolicy
+metadata:
+  name: app-{{ .client.Name }}-to-{{ .app.Name }}-p{{ .port }}
+  namespace: {{ .app.Namespace.Name}}
+spec:
+  targetRef:
+    group: policy.linkerd.io
+    kind: Server
+    name: {{ .app.Name }}-p{{ .port }}
+  requiredAuthenticationRefs:
+    - name: {{ .client.Name }}
+      namespace: {{ .client.Namespace.Name }}
+      kind: MeshTLSAuthentication
+      group: policy.linkerd.io

cmd/policygen/templates/linkerd/application/authorizationpolicy-net.yaml

@@ -2,7 +2,7 @@
 apiVersion: policy.linkerd.io/v1alpha1
 kind: AuthorizationPolicy
 metadata:
-  name: {{ .app.Name }}-p{{ .port }}
+  name: net-{{ .client.Name }}-to-{{ .app.Name }}-p{{ .port }}
   namespace: {{ .app.Namespace.Name}}
 spec:
   targetRef:
@@ -10,13 +10,7 @@ spec:
     kind: Server
     name: {{ .app.Name }}-p{{ .port }}
   requiredAuthenticationRefs:
-    - name: {{ .app.Name }}-p{{ .port }}
-      namespace: {{ .app.Namespace.Name }}
-      kind: MeshTLSAuthentication
-      group: policy.linkerd.io
-  {{- range $net := .clientNetworks }}
-    - name: {{ $net.Network.Name }}
+    - name: {{ .client.Name }}
       namespace: default
       kind: NetworkAuthentication
-      group: policy.linkerd.io
-  {{- end }}
+      group: policy.linkerd.io

cmd/policygen/templates/linkerd/application/meshtlsauthentication.yaml

@@ -2,13 +2,16 @@
 apiVersion: policy.linkerd.io/v1alpha1
 kind: MeshTLSAuthentication
 metadata:
-  name: {{ .app.Name }}-p{{.port}}
-  namespace: {{ .app.Namespace.Name }}
+  name: {{ .Name }}
+  namespace: {{ .Namespace.Name }}
 spec:
+  {{- if .ServiceAccounts }}
   identityRefs:
-  {{- range $sa := .serviceAccounts }}
+  {{- range $sa := .ServiceAccounts }}
     - kind: ServiceAccount
-      name: {{ $sa.Name }}
-      namespace: {{ $sa.Namespace }}
+      name: {{ $sa }}
   {{- end }}
+  {{- else }}
+    fail (printf "no service accounts defined for app %s" .Name )
+  {{- end}}